This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[Fix] Make sure pool metadata is removed on pool dissolve#12154
Merged
paritytech-processbot[bot] merged 15 commits intomasterfrom Sep 6, 2022
Merged
[Fix] Make sure pool metadata is removed on pool dissolve#12154paritytech-processbot[bot] merged 15 commits intomasterfrom
paritytech-processbot[bot] merged 15 commits intomasterfrom
Conversation
ruseinov
added
I3-bug
kianenigma
reviewed
Sep 1, 2022
kianenigma
added
D9-needsaudit 👮
muharem
approved these changes
Sep 1, 2022
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
Contributor
|
bot merge cancel |
|
Merge cancelled. |
Contributor
|
bot rebase |
|
Rebased |
kianenigma
reviewed
Sep 2, 2022
kianenigma
reviewed
Sep 2, 2022
kianenigma
reviewed
Sep 2, 2022
kianenigma
reviewed
Sep 2, 2022
kianenigma
reviewed
Sep 5, 2022
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
kianenigma
reviewed
Sep 5, 2022
kianenigma
reviewed
Sep 5, 2022
kianenigma
approved these changes
Sep 5, 2022
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Contributor
|
bot rebase |
|
Branch is already up-to-date |
Contributor
|
bot merge |
|
Waiting for commit status. |
jakoblell
added
D1-audited 👍
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…#12154) * [Fix] Make sure pool metadata is removed on pool dissolve * add migration * remove_metadata helper removed * fix typo and add a comment * fix pre_upgrade * fix migration * Update frame/nomination-pools/src/migration.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/nomination-pools/src/migration.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * address comments * fix comments * Update frame/nomination-pools/src/migration.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * address comments * permissions fix Co-authored-by: parity-processbot <> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12077